Skip to content

fix: use --loglevel error instead of silent for prettier format#2767

Merged
jar-stripe merged 2 commits into
masterfrom
jar/format-diagnostic
Jun 24, 2026
Merged

fix: use --loglevel error instead of silent for prettier format#2767
jar-stripe merged 2 commits into
masterfrom
jar/format-diagnostic

Conversation

@jar-stripe

Copy link
Copy Markdown
Contributor

Why?

When just format fails (e.g. prettier encounters a merge marker or syntax error in generated code), --loglevel silent swallows the error output entirely. This makes CI failures impossible to diagnose without reproducing locally.

What?

  • Changes --loglevel silent to --loglevel error in the format recipe
  • Errors (parse failures, file read issues) are now visible
  • Normal reformatting chatter ("reformatted N files") is still suppressed

See Also

--loglevel silent swallows all prettier output, including parse errors.
Switching to --loglevel error still suppresses the normal "reformatted N
files" chatter but surfaces actual failures (e.g. merge markers, syntax
errors in generated code).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Committed-By-Agent: claude
@jar-stripe jar-stripe marked this pull request as ready for review June 24, 2026 19:33
@jar-stripe jar-stripe requested a review from a team as a code owner June 24, 2026 19:33
@jar-stripe jar-stripe requested review from Copilot and kidus-stripe and removed request for a team June 24, 2026 19:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s just format command to stop suppressing Prettier’s error output, making CI formatting failures diagnosable when Prettier hits parse errors or unreadable files.

Changes:

  • Switches Prettier’s --loglevel from silent to error for the format recipe so errors are emitted while normal “reformatted” chatter remains suppressed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jar-stripe jar-stripe merged commit 4e6309e into master Jun 24, 2026
11 checks passed
@jar-stripe jar-stripe deleted the jar/format-diagnostic branch June 24, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants