Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connect SDK] UI for Connect SDK Example App #9276

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

simond-stripe
Copy link
Collaborator

Summary

This adds the UI for the Connect SDK example app. It's mirrored off of the other example apps in this repo (ex. PaymentSheetExample and FinancialConnectionsExample).

The app has UI for both components in the Connect SDK: AccountOnboarding and Payouts. Both are currently Beta and more can be added easily in the UI as the Connect SDK evolves.

Motivation

This is meant to:

  1. show off the capabilities of the SDK and
  2. demonstrate a canonical integration of the SDK to integrators

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

screen-1726357536

Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@simond-stripe simond-stripe added the accept-risky-change accept-risky-change label Sep 14, 2024
@simond-stripe simond-stripe marked this pull request as ready for review September 24, 2024 17:55
@simond-stripe simond-stripe requested a review from a team as a code owner September 24, 2024 17:55
@simond-stripe simond-stripe requested review from a team as code owners September 24, 2024 17:58
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │   0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │   0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │   0 B │   6.5 KiB │   6.5 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ -10 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ -10 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20244 │ 20244 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29462 │ 29462 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
    compressed    │   uncompressed   │                                           
──────────┬───────┼───────────┬──────┤                                           
 size     │ diff  │ size      │ diff │ path                                      
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 28.3 KiB │ -12 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.1 KiB │  +3 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    270 B │  -2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │  +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 54.9 KiB │ -10 B │ 126.4 KiB │  0 B │ (total)

private val menuItems = listOf(
MenuItem(
title = "Account Onboarding",
subtitle = "Show a localized onboarding form that validates data",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make these string resources?

cornerRadius = EmbeddedComponentManager.Appearance.CornerRadius()
@Composable
private fun BetaBadge() {
val borderColor = Color(0xffa7e7fc) // none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make these resources?

amk-stripe
amk-stripe previously approved these changes Sep 24, 2024
Copy link

@seankenkeremath-stripe seankenkeremath-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree about moving some things to res, looks good on my end! 👍

Base automatically changed from simond/connect-sdk-methods to master October 1, 2024 16:42
@simond-stripe simond-stripe dismissed stale reviews from seankenkeremath-stripe and amk-stripe October 1, 2024 16:42

The base branch was changed.

Copy link

@seankenkeremath-stripe seankenkeremath-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simond-stripe simond-stripe merged commit 5fce962 into master Oct 7, 2024
15 checks passed
@simond-stripe simond-stripe deleted the simond/connect-sdk-example-app branch October 7, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants