Introduce CheckoutController Builder, DI component, and scoped destroy()#13402
Merged
jaynewstrom-stripe merged 1 commit intoJul 10, 2026
Merged
Conversation
Wire CheckoutController through a Dagger component so it can be constructed via a Builder. Inject a @ViewModelScope CoroutineScope and cancel it in destroy(). No state-holder or loading behavior is included. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
amk-stripe
approved these changes
Jul 10, 2026
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
|
|
||
| @Singleton |
Collaborator
There was a problem hiding this comment.
why is this a singleton? I thought we could have multiple checkout controller instances for different checkout sessions: https://stripe.slack.com/archives/C0B9H95FK6F/p1783625928531009?thread_ts=1783616873.322879&cid=C0B9H95FK6F
Collaborator
Author
There was a problem hiding this comment.
Singleton in the dagger graph. No an actual singleton concept. We'll still support multiple controller instances with this.
jaynewstrom-stripe
deleted the
jaynewstrom/checkoutcontroller-builder-scaffolding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire CheckoutController through a Dagger component so it can be constructed via a Builder. Inject a @ViewModelScope CoroutineScope and cancel it in destroy(). No state-holder or loading behavior is included.
This is ultimately how merchants will create their checkout controller.