Extract FlagImageResolver for adaptive-pricing flag images#13401
Merged
jaynewstrom-stripe merged 1 commit intoJul 10, 2026
Conversation
Extract the adaptive-pricing flag-image resolution out of a standalone resolver so it can be reused and injected, and make FlagImageRepository DI-constructable via an @Inject constructor and a @DisplayDensity qualifier. FlagImageResolver caches images across mutations, reusing them when the integration and local currencies are unchanged and reporting AdaptivePricingFlagImageLoadFailed analytics on download failures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
jaynewstrom-stripe
force-pushed
the
jaynewstrom/checkout-flag-image-resolver
branch
from
4d7f254 to
d0951d6
Compare
| cached = internalState.flagImages, | ||
| ) | ||
| internalState = internalState | ||
| .copy(checkoutSessionResponse = response, flagImages = flagImages) |
Collaborator
Author
There was a problem hiding this comment.
This is technically new behavior. It should never really be triggered. But I want this in the new checkout controller. And it was easier to introduce it here than in one massive PR for checkout controller.
amk-stripe
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the adaptive-pricing flag-image resolution out of a standalone resolver so it can be reused and injected, and make FlagImageRepository DI-constructable via an @Inject constructor and a @DisplayDensity qualifier. FlagImageResolver caches images across mutations, reusing them when the integration and local currencies are unchanged and reporting AdaptivePricingFlagImageLoadFailed analytics on download failures.
Committed-By-Agent: claude
Summary
Motivation
Testing
Screenshots
Changelog