Display errors in NFC scanning flow#13391
Draft
samer-stripe wants to merge 1 commit into
Draft
Conversation
samer-stripe
force-pushed
the
samer/improve-errors-nfc-card-reader
branch
from
6826eed to
1a60bf9
Compare
samer-stripe
changed the title
samer-stripe
force-pushed
the
samer/improve-errors-nfc-card-reader
branch
from
1a60bf9 to
e532f5d
Compare
samer-stripe
force-pushed
the
samer/improve-errors-nfc-card-reader
branch
from
e532f5d to
e108490
Compare
samer-stripe
commented
Jul 11, 2026
|
|
||
| data class Error( | ||
| val userMessage: ResolvableString, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Will also output an error code that will be sent alongside our analytics in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display errors from NFC scanning flow under the instruction text when they are received. This text is placed under the coil without being cut off by the edges of the screen. Errors from the
NfcScanningViewModelare also propagated properly to the UI while theNfcCardScannerproduces a readable user message.Motivation
Error visibility for NFC Scanning
Testing