Skip to content

Fix stale browser session in Custom Tab when Firefox is the default browser 🪿✨ #13262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelphines-stripe wants to merge 1 commit into from
Closed

Fix stale browser session in Custom Tab when Firefox is the default browser 🪿✨ #13262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion connect/src/main/java/com/stripe/android/connect/StripeConnectRedirectActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ class StripeConnectRedirectActivity : Activity() {
// - intent flags FLAG_ACTIVITY_SINGLE_TOP and FLAG_ACTIVITY_CLEAR_TOP
// With the task cleared, the activity finishes in `onNewIntent()`
try {
val customTabsIntent = CustomTabsIntent.Builder().build()
val customTabsIntent = CustomTabsIntent.Builder()
.setShareState(CustomTabsIntent.SHARE_STATE_OFF)

@maragues-stripe maragues-stripe Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, SHARE_STATE_OFF controls whether Share button is displayed or not

Explicitly does not show a share option in the tab.

Which is completely unrelated to what you wrote in the PR.

SHARE_STATE_OFF is the documented mechanism for requesting a Custom Tab that is isolated from the browser's regular session

Did you test that this really fixes the issue? If it does, it sounds more like a Firefox glitch than an official fix.

.build()
CustomTabsClient.getPackageName(this, null)?.let { browserPackage ->
customTabsIntent.intent.setPackage(browserPackage)
}
Expand Down
Loading