Support 2fa in LinkActivityViewModel #10040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APK |
toluo-stripe
force-pushed
the
tolu/link/2fa_vm
branch
from
d42b115 to
ede5b96
Compare
toluo-stripe
commented
Jan 30, 2025
Comment on lines
182
to
198
| val linkAccount = linkAccountManager.linkAccount.value | ||
| val accountStatus = linkAccountManager.accountStatus.first() | ||
| when (accountStatus) { | ||
| AccountStatus.Verified, | ||
| AccountStatus.SignedOut, | ||
| AccountStatus.Error -> { | ||
| _linkScreenState.value = ScreenState.Link | ||
| } | ||
| AccountStatus.NeedsVerification, | ||
| AccountStatus.VerificationStarted -> { | ||
| if (linkAccount != null && startWithVerificationDialog) { | ||
| _linkScreenState.value = ScreenState.VerificationDialog(linkAccount) | ||
| } else { | ||
| _linkScreenState.value = ScreenState.Link | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This will determine whether we render the 2fa dialog or the default link flow
toluo-stripe
commented
Jan 30, 2025
Comment on lines
+149
to
+153
| fun linkScreenScreenCreated() { | ||
| viewModelScope.launch { | ||
| navigateToLinkScreen() | ||
| } | ||
| } |
There was a problem hiding this comment.
This will be called from the UI when the default link flow is presented. It will navigate to the correct screen. Navigating early causes issues when the nav graph isn't registered yet. This is an example from the proof of concept PR
toluo-stripe
force-pushed
the
tolu/link/2fa_vm
branch
from
d280b57 to
d382fea
Compare
amk-stripe
previously approved these changes
Jan 30, 2025
| .build() | ||
| .viewModel | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| internal sealed interface ScreenState { | ||
| data class VerificationDialog(val linkAccount: LinkAccount) : ScreenState | ||
| data object Link : ScreenState |
There was a problem hiding this comment.
it might be useful to call Link here something like FullScreen instead. Since this is all Link, the current naming is a bit vague.
No need to address now -- feedback for a future improvement here
There was a problem hiding this comment.
I agree. I'll update when I add the remaining components
Clean up vm use false as default test values Fix tests
toluo-stripe
force-pushed
the
tolu/link/2fa_vm
branch
from
d382fea to
a71ae1e
Compare
amk-stripe
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates to LinkActivityViewModel with states that render [loading, verification, fullscreen] flows
Motivation
JIRA
Testing
Screen Recording
Screen.Recording.2025-01-30.at.6.49.15.PM.mov
Changelog