This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Kms vault #51
Merged
Kms vault #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
tombentley
reviewed
Aug 25, 2022
There was a problem hiding this comment.
Thanks @chris-giblin, I've made a first pass.
Presumably a production deployment would use HTTPS, so eventually we'll need tests (and perhaps configs?) for that. I further assume you don't want to bit this off here, which is fine, but can you open an issue for this so we don't forget?
kms-vault/src/main/java/io/strimzi/kafka/topicenc/kms/vault/VaultKms.java
Show resolved
Hide resolved
kms-vault/src/main/java/io/strimzi/kafka/topicenc/kms/vault/VaultKms.java
Outdated
Show resolved
Hide resolved
kms-vault/src/main/java/io/strimzi/kafka/topicenc/kms/vault/VaultKms.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
The URL in the unit test is indeed http. That is the protocol used by Vault's dev mode which the test assumes. This should go away when testcontainers are introduced through Isssue #37 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Vault as a KMS provider using Java ServiceLoader