-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen the restrictions for TLS options in type: custom
listener authentication to enable new features
#11052
base: main
Are you sure you want to change the base?
Conversation
…tion Signed-off-by: Jakub Scholz <[email protected]>
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.KafkaListenerAuthenticationCustom.adoc
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.KafkaListenerAuthenticationCustom.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jakub.
Would it make sense to mention this with the config exceptions in KafkaClusterSpec schema reference, as with allowed ssl
config for cipher suites?
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.KafkaListenerAuthenticationCustom.adoc
Outdated
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.KafkaListenerAuthenticationCustom.adoc
Outdated
Show resolved
Hide resolved
...ntation/api/io.strimzi.api.kafka.model.kafka.listener.KafkaListenerAuthenticationCustom.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: PaulRMellor <[email protected]> Signed-off-by: Jakub Scholz <[email protected]>
Those are different than this. This does not apply to the |
Type of change
Description
There are some feature requests that pop-up from time to time related to
type: tls
authentication. For example:ssl.principal.mapping.rules
when using a custom CA with more complex subjectsRight now, when using the
type: custom
authentication, we do not allow to configure any options starting withssl.
. This makes it impossible to usetype custom
authentication for the features described above.This PR loosens the restriction and forbids only the keystore configuration options - i.e. starting with
ssl.keystore.
. But let's the users configure other TLS options. That means that the TLS keystore will be still configured by Strimzi based on the listener configuration. But users could for example freely:ssl.principal.mapping.rules
for given listenerFor example, the 3 feature requests listed above can be done with following configuration:
This:
This should resolve #2900 and resolve #6566
Checklist