Skip to content

web: add keep vault note unlocked setting #8077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

01zulfi
Copy link
Collaborator

@01zulfi 01zulfi commented May 9, 2025

Signed-off-by: 01zulfi [email protected]

@01zulfi 01zulfi marked this pull request as ready for review May 12, 2025 05:52
@01zulfi 01zulfi force-pushed the web/keep-vault-note-unlocked-setting branch 2 times, most recently from 5bea4e2 to c1a99df Compare May 12, 2025 05:55
@@ -77,4 +77,11 @@ export class NoteItemModel extends BaseItemModel {
}
return tags;
}

async isLockedNotePasswordFieldVisible() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isLockedNotePasswordFieldVisible is working well, nice approach to add this one

}}
data-test-id="vault-unlocked"
>
<Unlock size={10} />
<Unlock size={12} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work better

01zulfi added 2 commits May 20, 2025 08:50
* tests
* docs
* minor refactors
* bug fix: AppStore.isVaultCreated was not being set to true when note was locked

Signed-off-by: 01zulfi <[email protected]>
@01zulfi 01zulfi force-pushed the web/keep-vault-note-unlocked-setting branch from c1a99df to 89828cf Compare May 20, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants