Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

fix #456: startupmode of external subscription does support #477

Open
wants to merge 1 commit into
base: release-1.9
Choose a base branch
from
Open

fix #456: startupmode of external subscription does support #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/java/org/apache/flink/streaming/connectors/pulsar/PulsarTableSourceSinkFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ private StartupOptions getStartupOptions(DescriptorProperties descriptorProperti
});
return StartupMode.SPECIFIC_OFFSETS;

case PulsarValidator.CONNECTOR_STARTUP_MODE_VALUE_EXETERNAL_SUB:
case PulsarValidator.CONNECTOR_STARTUP_MODE_VALUE_EXTERNAL_SUB:
subName.add(descriptorProperties.getString(CONNECTOR_EXTERNAL_SUB_NAME));
return StartupMode.EXTERNAL_SUBSCRIPTION;

Expand Down
4 changes: 3 additions & 1 deletion pulsar-flink-connector/src/main/java/org/apache/flink/table/descriptors/PulsarValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class PulsarValidator extends ConnectorDescriptorValidator {
public static final String CONNECTOR_STARTUP_MODE_VALUE_EARLIEST = "earliest";
public static final String CONNECTOR_STARTUP_MODE_VALUE_LATEST = "latest";
public static final String CONNECTOR_STARTUP_MODE_VALUE_SPECIFIC_OFFSETS = "specific-offsets";
public static final String CONNECTOR_STARTUP_MODE_VALUE_EXETERNAL_SUB = "external-subscription";
public static final String CONNECTOR_STARTUP_MODE_VALUE_EXTERNAL_SUB = "external-subscription";
public static final String CONNECTOR_SPECIFIC_OFFSETS = "connector.specific-offsets";
public static final String CONNECTOR_SPECIFIC_OFFSETS_PARTITION = "partition";
public static final String CONNECTOR_SPECIFIC_OFFSETS_OFFSET = "offset";
Expand Down Expand Up @@ -121,6 +121,8 @@ public static String normalizeStartupMode(StartupMode startupMode) {
return CONNECTOR_STARTUP_MODE_VALUE_LATEST;
case SPECIFIC_OFFSETS:
return CONNECTOR_STARTUP_MODE_VALUE_SPECIFIC_OFFSETS;
case EXTERNAL_SUBSCRIPTION:
return CONNECTOR_STARTUP_MODE_VALUE_EXTERNAL_SUB;
}
throw new IllegalArgumentException("Invalid startup mode.");
}
Expand Down