Conversation
|
Can you just squash these three commits into a single one? |
|
@GitGab19 Done. |
GitGab19
left a comment
GitGab19
left a comment
There was a problem hiding this comment.
Just discovered it's not able to parse a taproot address.
I'm using this example to validate it: bc1p5d7rjq7g6rdk2yhzks9smlaqtedr4dekq08ge8ztwac72sfr9rusxg3297
|
@GitGab19 At this point this is beyond my skill level. Claude suggested this 2a3b991 which seemed crazy over-engineering, but apparently it's how it should be handled according to the dependency. Puzzling that this many new things have to be imported. I pushed so you can test, review and then see if there's a better way to do it. If you can do it better on your own, take over please, at this stage I am taking Claude output too heavily for this PR. |
|
Looks like the correct thing to do: bitcoinjs/bitcoinjs-lib#1919 (comment) |
Add validation isValidBitcoinAddress now takes the specific network the user chose improve error message Improve error message fix lint error in isValidBitcoinAddress
2 participants
Closes #24
Successor of #27