Worker Specific Hashrate Tracking Extension #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitGab19
force-pushed
the
extend-submit-shares-extended
branch
from
81852c2 to
1f5150f
Compare
TheBlueMatt
reviewed
Dec 5, 2024
TheBlueMatt
reviewed
Dec 5, 2024
|
After yesterday's call, I noticed that there were some misunderstandings about this PR. So I just pushed a new commit to clarify this point of discussion. Please @Fi3 @TheBlueMatt review the last commit: 9260a15 |
GitGab19
force-pushed
the
extend-submit-shares-extended
branch
from
9260a15 to
445048c
Compare
Fi3
reviewed
Feb 1, 2025
03-Protocol-Overview.md
Outdated
| ### Usage Guidelines | ||
|
|
||
| - **TLV fields MUST be placed at the end of the message payload.** This ensures compatibility with existing Stratum V2 messages. | ||
| - **Order of TLV fields is not significant.** Since all extensions are negotiated beforehand, the recipient MUST scan for TLV fields using their Type identifiers rather than relying on a fixed order. |
There was a problem hiding this comment.
I would add that in the extension order matter. If an extension add more the one field you will have first field of ext A is T1 second of ext A is T2 ecc ecc
I think that is better to specify such thing here rather than in every extension to avoid confusion.
There was a problem hiding this comment.
Good point, I will add this clarification in a new commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extension to directly send a
user_identityfield inside aSubmitSharesExtended. Theuser_identityfield is limited to a maximum of 32 bytes-length to not increase too much the additional bandwidth consumption for extended shares submissions.This PR follows #112.