[TestNet] Add Delegatedtransfer method to NonFungibleToken#95
Open
quantumagi wants to merge 14 commits intostratisproject:masterfrom
Open
[TestNet] Add Delegatedtransfer method to NonFungibleToken#95quantumagi wants to merge 14 commits intostratisproject:masterfrom
quantumagi wants to merge 14 commits intostratisproject:masterfrom
Conversation
Contributor
|
Hi @quantumagi - Can we make this PR only target Testnet please |
quantumagi
changed the title
Contributor
Author
Done. |
YakupIpek
approved these changes
Aug 29, 2023
| var uid = Guid.NewGuid(); | ||
|
|
||
| string url = $"?uid={Convert.ToHexString(uid.ToByteArray().Reverse().ToArray())}&action=DelegatedTransfer&from={this.AddressToString(ownerAddress)}&to={this.AddressToString(targetAddress)}&tokenId=1"; | ||
| string url = $"?uid={Convert.ToHexString(uid.ToByteArray().Reverse().ToArray())}&method=DelegatedTransfer&from={this.AddressToString(ownerAddress)}&to={this.AddressToString(targetAddress)}&tokenId=1"; |
Contributor
There was a problem hiding this comment.
can we use uid as string for avoid endian stuff?
Contributor
Author
There was a problem hiding this comment.
lets rather keep uid compatible with UInt128/Guid,
| public void DelegatedTransfer(string url, byte[] signature) | ||
| { | ||
| string[] args = SSAS.GetURLArguments(url, new string[] { "uid", "action", "from", "to", "tokenId" }); | ||
| string[] args = SSAS.GetURLArguments(url, new string[] { "uid", "method", "from", "to", "tokenId" }); |
Contributor
There was a problem hiding this comment.
We have to add contract address here ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NFT Ticket Contract
Compiler Version
Contract Hash
Contract Byte Code