Skip to content

Run testing repo tests against PR#3545

Draft
mulkieran wants to merge 2 commits intostratis-storage:masterfrom
mulkieran:testing-test
Draft

Run testing repo tests against PR#3545
mulkieran wants to merge 2 commits intostratis-storage:masterfrom
mulkieran:testing-test

Conversation

@mulkieran
Copy link
Copy Markdown
Member

No description provided.

@mulkieran
Copy link
Copy Markdown
Member Author

Next time, add temporary commit to not run Packit stuff, for that is a waste.

@packit-as-a-service
Copy link
Copy Markdown

Cockpit tests failed for commit 06426fd. @martinpitt, @jelly, @mvollmer please check.

@mulkieran
Copy link
Copy Markdown
Member Author

mulkieran commented Feb 26, 2024

Cockpit tests failed for commit 06426fd. @martinpitt, @jelly, @mvollmer please check.

Plz ignore. We should be skipping Packit tests anyway...for this PR.

@mulkieran mulkieran force-pushed the testing-test branch 2 times, most recently from d3fc6b2 to 30b3d6f Compare February 26, 2024 19:34
@martinpitt
Copy link
Copy Markdown
Contributor

@mulkieran FTR, that test failure actually wasn't statis' fault, but an (unrelated) kernel regression. We are currently investigating that. Sorry for the noise on PRs, this is a hard one to debug.

rawhide even passed.

What I want to say is: Feel free to run such tests also against cockpit-storage, if it helps you/you want additional coverage.

@mulkieran mulkieran force-pushed the testing-test branch 4 times, most recently from d293d76 to a5e6a83 Compare March 11, 2024 16:13
@mulkieran
Copy link
Copy Markdown
Member Author

To test stratis-storage/ci#510

@mulkieran
Copy link
Copy Markdown
Member Author

Testing stratis-storage/ci#511

@mulkieran mulkieran force-pushed the testing-test branch 3 times, most recently from 36b0e6b to 3ff9038 Compare March 12, 2024 00:29
@mulkieran mulkieran force-pushed the testing-test branch 3 times, most recently from e1bb325 to 9367b37 Compare June 25, 2024 18:57
@mulkieran
Copy link
Copy Markdown
Member Author

mulkieran commented Jun 25, 2024

We are trying to exactly duplicate the behavior of the successful manual test in the auto-test: stratis-storage/testing@35b083c .

@mulkieran
Copy link
Copy Markdown
Member Author

We are trying to exactly duplicate the behavior of the successful manual test in the auto-test: stratis-storage/testing@35b083c .

But alas, the test succeeds.

@mulkieran mulkieran force-pushed the testing-test branch 2 times, most recently from c30709a to 9367b37 Compare June 28, 2024 02:02
@mulkieran
Copy link
Copy Markdown
Member Author

I believe the test will fail now...

@mulkieran
Copy link
Copy Markdown
Member Author

We expect tests to succeed now.

@mulkieran mulkieran force-pushed the testing-test branch 2 times, most recently from 36a36e4 to 943e0a6 Compare January 24, 2025 20:34
@mulkieran
Copy link
Copy Markdown
Member Author

I've seen this failure once before...error_if_no_space feature has not yet been written to the pool-level metadata, but the current metadata expects it. This is a flaky failure, but persistent.

@mulkieran mulkieran force-pushed the testing-test branch 2 times, most recently from b81e7d6 to 81503c0 Compare February 18, 2025 18:53
@mulkieran mulkieran force-pushed the testing-test branch 3 times, most recently from 2da49c5 to f87735b Compare March 11, 2025 17:30
@mulkieran mulkieran force-pushed the testing-test branch 2 times, most recently from e89775f to 9dd0e78 Compare April 10, 2025 14:40
@mulkieran mulkieran force-pushed the testing-test branch 2 times, most recently from 4b7e44b to 272bd76 Compare July 24, 2025 13:55
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 18, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran
Copy link
Copy Markdown
Member Author

mulkieran commented Aug 18, 2025

Such a simple change in D-Bus monitor script and yet everything is going wrong...because linter didn't catch a typo, alas.

@mulkieran
Copy link
Copy Markdown
Member Author

There were two test ERRORs which were unwanted and some much desired test FAILures, it looks like stratis-storage/testing#328 is working exactly as intended.

Signed-off-by: mulhern <amulhern@redhat.com>
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3545-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran
Copy link
Copy Markdown
Member Author

/packit build

@mulkieran
Copy link
Copy Markdown
Member Author

Rerun builds with modified spec file.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Copy Markdown
Member Author

/packit build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants