Reapply "Prototype of bindgen workaround usage"#449
Reapply "Prototype of bindgen workaround usage"#449mulkieran merged 2 commits intostratis-storage:masterfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'm just curious to see if this builds now. |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
@mulkieran For some reason it appears it's building on every system but rawhide. On rawhide I'm seeing the same errors as before. |
990bf0e to
a0dd1f5
Compare
|
bumping this once more to see how it goes. |
|
Now it doesn't build on any release. Feel like this could be an LLVM update that went through. |
|
@mulkieran Honestly this is really concerning to me only because it seems to work everywhere else I've tested other than in the Fedora infrastructure. |
We should try to bring it up w/ toolchain team. May take a little while though. |
a0dd1f5 to
d38c6d2
Compare
|
Reconfirming failure to build |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
d38c6d2 to
0cb56ca
Compare
|
This now builds on Fedora. It may be due to the recent bump to Rust 1.92.0 in Fedora. So maybe this is finally mergeable. I don't think it is. The problem is that there is an order, and it succeeds in building the -sys library after it has failed to build the libcryptsetup library. So still no go. |
|
Relevant failures are here: https://copr.fedorainfracloud.org/coprs/packit/stratis-storage-libcryptsetup-rs-449/build/9970294/ |
This reverts commit b18cdb2.
22be47c to
ce1099a
Compare
|
@jbaublitz Following the suggestion at stratis-storage/project#784 (comment) we have what looks like success. |
|
@mulkieran I read the comment and it made a lot of sense so I'm glad it appears to fix the problem! |
Signed-off-by: mulhern <amulhern@redhat.com>
ce1099a to
a678457
Compare
|
Packit builds will fail temporarily, but will succeed once merged. |
|
Packit builds succeeding was an artifact of the -sys builds running second, they tend to always succeed. Double checking, though. |
Related stratis-storage/project#784