fix(bidi): export BidiGeminiLiveModel and BidiOpenAIRealtimeModel #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing exports to __all__ in bidi/models/__init__.py - Fixes ImportError when importing from top-level models module - Aligns with documentation examples that use these imports Resolves import issues where users following docs get: ImportError: cannot import name 'BidiOpenAIRealtimeModel' from 'strands.experimental.bidi.models' Related documentation: - https://strandsagents.com/latest/documentation/docs/user-guide/concepts/experimental/bidirectional-streaming/models/gemini_live/ - https://strandsagents.com/latest/documentation/docs/user-guide/concepts/experimental/bidirectional-streaming/models/openai_realtime/
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 tasks
cagataycali
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes missing exports in
strands.experimental.bidi.modelsmodule that causedImportErrorwhen users followed the official documentation examples.Problem:
Users following documentation at:
Were encountering:
Solution:
BidiGeminiLiveModelandBidiOpenAIRealtimeModelto imports__all__list insrc/strands/experimental/bidi/models/__init__.pyWhy this matters:
The classes exist and work perfectly when imported directly (
from .openai_realtime import BidiOpenAIRealtimeModel), but were not exposed at the package level, causing confusion for users following the docs.Related Issues
Discovered during testing of bidirectional streaming examples. No existing issue.
Documentation PR
No documentation changes needed - this PR aligns code with existing documentation.
Type of Change
Bug fix
Testing
How have you tested the change?
Manual Testing:
Verification:
Tested that imports work from top-level
strands.experimental.bidi.modelsVerified existing direct imports still work:
from strands.experimental.bidi.models.openai_realtime import BidiOpenAIRealtimeModelConfirmed no breaking changes to existing code
I ran
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.