Fix CVE-2020-36843 by rejecting malleable signatures wih s>=L. #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Hopefully @str4d is still able to release the project in 2025 and publish it to maven central again. 👍 |
|
@str4d could you please review and hopefully merge this PR? |
|
@str4d any news on when we can expect a merge in autumn 2025? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CVE-2020-36843 and #95
I did my best to make the project compile and test under openjdk-17 with minimal modifications.
I had to drop support for java-1.7 but hopefully retained compatibility with java-8.
TIA for starting the discussion on this contribution, so that we get this old CVE fixed in 2025.