Repository navigation
Add Korean (ko) interface language and write Hangul into PDFs - #2528
Open
luff-mitchell wants to merge 2 commits into
Open
luff-mitchell wants to merge 2 commits into
luff-mitchell wants to merge 2 commits into
Conversation
- ko.tsv: 2,669 clean-room entries written from the English meaning (합니다체/해요체 mix as in the catalog header); covers every key the other catalogs have. Drafted by Claude from the English strings only; reviewed by a Korean-speaking contributor with Google Gemini (55 edits, mostly terms: Redact, Sanitize, Flatten, Output intent). - Register `ko` in LANGUAGES and in the date languages (month/weekday names). - Fonts: `Hang` script support. ui_korean_fonts() picks craft-fonts faces covering Hangul; Korean mode puts them ahead of the Japanese CJK faces, and the web build embeds them. Needs NanumGothic (OFL-1.1) in storytold/craft-fonts, otherwise the build still works and falls back to an installed Hangul face (Malgun Gothic, Apple SD Gothic Neo, Nanum), read at runtime and never embedded. - Tests: Korean glyph/ordering test, date names, catalog consistency lists. - Docs: localization.md, localization-parity.md, gaps.md storytold#14, ROADMAP.md, ATTRIBUTION. Not covered here: writing Hangul into edited PDFs (next commit). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HxYuVzYKY6M4RXSDFiCpKR
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HxYuVzYKY6M4RXSDFiCpKR
luff-mitchell
force-pushed
the
feat/ko-catalog
branch
from
October 16, 2026 12:15
49a1b0f to
3a1d703
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds Korean (한국어,
ko) as an interface language and lets PdfCraft write Hangul into PDFs.crates/ui-egui/src/i18n/ko.tsv: full catalog, 2,672 entries (menus, tools, dialogs, notices, plurals;{placeholders}and trailing "…" match the English source). Registered inLANGUAGES.crates/engine/src/dates.rs: Korean month and day names for date fields (mirrors the interface languages; the existing test enforces it).CRAFT_FONTS_DIR), ahead of the Japanese faces in Korean mode. Builds without it use an installed Hangul face at runtime (Malgun Gothic, Apple SD Gothic Neo, Nanum); nothing is embedded.localization.md,localization-parity.md,gaps.md,ROADMAP.md,ATTRIBUTION.*.Provenance and translation disclosure
mainafter that review (word count, Full Screen prompt, untagged content, print notices, the password minimum, the revision and snapshot notices) are Claude's draft and not yet reviewed. Further wording fixes from other native speakers are welcome.How you verified it
cargo fmt --check-D warningsonpdfcraft-ui-egui,pdfcraft-engine,pdfcraft-fonts,pdfcraft-editmainf0c9901 on 2026-10-16; tests on the crates I changed: engine 274, edit 158, fonts 70, ui-egui lib 437 all pass, and withCRAFT_FONTS_DIRset thefonts.rsKorean glyph test passes too. I did not run the whole workspace.main(afa8e18) pass on the rebased branch, becausemainhas since fixed them. None involvedko.cargo xtask layersandcargo xtask assetspdftoppm; the UI was run on Windows with the Hang font and shows Hangul correctly.Never-crash / Security
No new
unwrap/expect/panic!in non-test code, no indexing with input-derived positions, nounsafe, no new network access, no change to--rootconfinement.Anything a reviewer should look at first
localization-parity.md).?. This is the existing limit for every non-Latin script, and is not changed here. It would be a separate follow-up.parity/has no Korean-interface row, so none was changed.🤖 Generated with Claude Code
https://claude.ai/code/session_01HxYuVzYKY6M4RXSDFiCpKR