Repository navigation
Conversation
Problem: the hardware-decoding work (storytold#819) needs a newer FilmCraft than the pinned 2c5ba7a, and the pin bump should be reviewable apart from it. Fix: move all filmcraft-* deps to 4e2d0bc2. Adapt to MediaInfo.audio -> audio_streams and VideoStreamInfo.hdr; ask the pool for a quarter into the frame because FilmCraft now rounds requests half up; adapt rotation and the AAC downmix; use Decoder::with_threads(1) in the VP9 tests. No filmcraft-platform, no hardware setting. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Merged current main and resolved conflicts in Cargo.toml (kept the new filmcraft rev for interchange/project/geom, and kept main's symphonia aiff entry). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #804.
Why
#819 (hardware video decoding) needs a newer FilmCraft than the pinned
2c5ba7a. The pin bump is the only part of that PR that touches existing code, so it is split out here to be reviewed on its own. #819 builds on this PR. This PR adds nofilmcraft-platformdependency, no hardware setting and noregister()call.What changed
All
filmcraft-*git deps move from2c5ba7a(2026-10-03) to FilmCraftmain4e2d0bc2(2026-10-10).MediaInfo.audiobecameaudio_streams(audio()/has_audio()), andVideoStreamInfogainedhdr. Mechanical fixes ininterchange,mediaand two tests.pool.rs). This fixed the export round-trips for H.264 / HEVC / AV1 / ProRes and the automationqa::kinetictest.filmcraft_vp9::Decoder::new()now uses frame threads, so a picture can come out of a later call. The VP9 encoder tests expect one picture per call, so they useDecoder::with_threads(1). Only test code uses the VP9 decoder.media/src/probe.rs,downmix.rs,pool.rs).filmcraft-export(render,text,captions,audio-dsp). Nofilmcraft-platform.What maintainers must decide
Only the pin: whether to move to FilmCraft
4e2d0bc2.Gates
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings, fullcargo testof effectcraft-media, -export, -interchange, -render, -engine, -host and -vp9enc (all green),cargo xtask layers,cargo xtask wasm. Assets unchanged.🤖 Generated with Claude Code