Repository navigation
Restore GNOME Wayland window controls without bundled fonts - #1598
Open
danielmigueltejedor wants to merge 3 commits into
Open
danielmigueltejedor wants to merge 3 commits into
danielmigueltejedor wants to merge 3 commits into
Conversation
danielmigueltejedor
marked this pull request as ready for review
October 16, 2026 13:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNOME Wayland leaves window decorations to the client, but the desktop build did not enable a frame renderer. Enable winit’s Adwaita vector minimize, maximize/restore and close controls without a title-font renderer. The outer client frame intentionally omits title text; window titles remain available to the desktop and EffectCraft keeps its existing header UI.
The feature is Linux-only. X11 and compositors offering server decorations retain their existing frame path and backend-selection behavior. Include sctk-adwaita’s MIT notice in packaged NOTICE. No font or other asset files are added, no Cantarell is embedded, and no engine, GPU, UI implementation or tests change.
Validation with Rust 1.98.1 on Linux:
--no-fail-fast, usingLANG=C.UTF-8,LC_ALL=C.UTF-8,LANGUAGE=enso label-based tests use their expected English: 3,415 passed, 26 ignored, 6 failed. All six failures are existing GPU/CPU pixel comparisons:tests_fx_noise::{dust_strict_threshold_boundaries,dust_threshold_on_quantized_input,large_radius_medians,medians},tests_fx_stylize::posterize_thresholds_strobe_vignette,tests_fx_transition::grid_and_scale_wipes. Running the entire GPU library suite on a clean archive of unchanged upstream main0311bdc34d0dc10c2d18ff7875b4f52d483e5e27with the same compiler/profile/device environment gives 206 passed and the exact same six failures. No assertions are skipped or weakened; the repository gate retains these baseline comparison failures.KDE itself and native Windows/macOS execution were not available for runtime testing. Maintainers may need to authorize this fork’s GitHub Actions checks.