issue #6763 : set a better value for process in the manager webpack config #6767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-bugfix-process-variable-set-to-true.storybook.now.sh |
libetl
commented
May 11, 2019
| new CaseSensitivePathsPlugin(), | ||
| new Dotenv({ silent: true }), | ||
| // graphql sources check process variable | ||
| new DefinePlugin({ | ||
| process: JSON.stringify(true), | ||
| process: { browser: true, env: stringified }, | ||
| NODE_ENV: JSON.stringify(process.env.NODE_ENV), |
There was a problem hiding this comment.
is the above NODE_ENV key necessary or is it a bug by the way (global.NODE_ENV) ?
leaving as it is for now.
shilman
approved these changes
May 12, 2019
|
@ndelangen can you take a look at this? i think you wrote the code it's replacing |
|
@shilman is this still necessary ? |
|
@libetl As far as I know this is still necessary. @ndelangen ping |
ndelangen
approved these changes
May 17, 2019
|
Yet another conflict... With myself. |
This was referenced Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
I have fixed the trouble with libraries making use of the process variable.
In the manager configuration, the variable is set to true,
Which causes several troubles when using additional libraries (like crypto)
So instead of true, I am setting a more relevant value
this also fixes issue #6763
How to test
If your answer is yes to any of these, please make sure to include it in your PR.