feat: speed run photo uploader #289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than doing this in the headless component, do it in the provider so that hook users also get a page of results
weird timing issues occur when you try to do this in the provider - move it to the hook to get around them
very ugly, but a demonstration of the simplest possible photo upload app, implemented in 5 minutes
|
it would be cool to refine this app to stay basically as simple but leverage styling etc where possible, and then put it in the repo as an example of good code, but also have a 5 min speed run building it. None of this is urgent if what we have here is enough to unblock @gobengo's research. |
I think it's better to have this in the provider so that anyone using this context gets a page of results previously I thought this wouldn't work, but that was just because I wasn't doing a good job with dependency management - now that it's configured to re-run the load any time the space or agent change, it seems to work as expected
travis
force-pushed
the
photo-uploader
branch
from
e449b3d
to
74941b8
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 74941b8:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very ugly, but a demonstration of the simplest possible photo upload app, implemented in 5 minutes:
photo-uploader-speedrun.mp4