Repository navigation
Require completed FBC tests and exact stage artifacts - #117
Merged
dfarrell07 merged 1 commit intoOct 13, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dfarrell07 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Oct 12, 2026
dfarrell07
force-pushed
the
fix/fbc-exact-release-verification
branch
from
October 13, 2026 16:08
ac4db47 to
128898b
Compare
dfarrell07
changed the title
Reject unfinished integration evidence and constrain requested snapshots without relaxing source provenance. Verify successful stage publication, matching snapshot images and bundle digests before printing catalog URLs. Require the literal Quay registry and the onboarding lifecycle contract. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07
force-pushed
the
fix/fbc-exact-release-verification
branch
from
October 13, 2026 16:34
128898b to
53ca1eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FBC readiness could accept unfinished markers or select an older snapshot, and QE URL lookup could return a snapshot image without successful stage publication. Require completed aggregate/scenario evidence and exact Release → snapshot → immutable fragment identities, including the requested bundle version/digest.
Add optional exact snapshot selection without weakening merged-source or push-pipeline provenance. Verify all applicable active targets before returning stage URLs;
--ocpselects an individual target. Remove snapshot publication fallback and human-row parsing. Raw mode performs no Jira writes; non-raw mode retains its existing authorization requirement.Extend the existing onboarding contract to require the lifecycle task and source/parameter forwarding. Reuse existing helpers; add no release framework or evidence store. Manual recovery guidance is in #115; retained stage records are in #116.
Validation: full
make testand mandatory commit hook pass, including incomplete/ambiguous evidence, invalid exact selection, wrong version/OCP/environment or registry, production artifacts, image/bundle mismatch, extraction failure and partial scope. The helper independently extracted all six live 0.23.4 catalogs and returned their verified QE digests. No policy or provenance gate is relaxed.