Add variants Nucleo-U5A5ZJ-Q and generic U595ZITxQ,U595ZJTxQ,U599ZITx… #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @patricklaf |
fpistm
requested changes
May 14, 2025
variants/STM32U5xx/U595Z(I-J)TxQ_U599Z(I-J)TxQ_U5A5ZJTxQ_U5A9ZJTxQ/generic_clock.c
Outdated
Show resolved
Hide resolved
variants/STM32U5xx/U595Z(I-J)TxQ_U599Z(I-J)TxQ_U5A5ZJTxQ_U5A9ZJTxQ/variant_NUCLEO_U5A5ZJ_Q.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
14
to
15
| * Automatically generated from STM32U595ZITx.xml, STM32U595ZJTx.xml | ||
| * STM32U5A5ZJTx.xml |
There was a problem hiding this comment.
Seems not the correct PeripheralPins.h file.
Is it really needed to have a custom one ?
There was a problem hiding this comment.
Hi @fpistm ,
Thanks for your review.
The variants are inspired by \U575Z(G-I)TxQ_U585ZITxQ.
The Nucleo-U5A5ZJ-Q is very similar to the Nucleo-U575ZI-Q, so I used the same layout.
BTW in the existing variants used as model, LPUART1 is not configured.
There was a problem hiding this comment.
OK. It is not an issue as the clock config can be redefined.
Anyway the file is not correct as it differs from the PeripheralPins.c and no pins seems to be removed.
The one from Nucleo-U575ZI-Q comments some USB pins not needed.
github-project-automation
bot
moved this from In progress
to Needs review
in STM32 core based on ST HAL
…U5A9ZJTxQ Signed-off-by: patricklaf <[email protected]> Co-authored-by: Frederic Pillon <[email protected]>
fpistm
approved these changes
May 14, 2025
github-project-automation
bot
moved this from Needs review
to Reviewer approved
in STM32 core based on ST HAL
Signed-off-by: patricklaf <[email protected]> Co-authored-by: Frederic Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds variants for the Nucleo-U5A5ZJ-Q and for generic boards based on U595ZITxQ, U595ZJTxQ, U599ZITxQ, U599ZJTxQ, U5A5ZJTxQ and U5A9ZJTxQ.
Only the Nucleo board has been tested with the CheckVariant sketch with the following result:
On a real project, I2C and SPI were used with success.