Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE call blitzgseas geneset libraries #2739

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

xzhou82
Copy link
Collaborator

@xzhou82 xzhou82 commented Feb 5, 2025

Description

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@karishma-gangwani
Copy link
Contributor

@robinpaul85 please disable p-value cutoff in gsea temporarily for validation/testing.

@robinpaul85 robinpaul85 force-pushed the issue.2737 branch 2 times, most recently from 9d107f6 to c4fe69a Compare February 6, 2025 18:28
@robinpaul85 robinpaul85 marked this pull request as ready for review February 6, 2025 20:17
@karishma-gangwani
Copy link
Contributor

karishma-gangwani commented Feb 6, 2025

I am not seeing title cases for ORA menu when 1 group is selected.
image

Resolved in other PR

elif table_name == "KEGG--blitzgsea": # Parse from blitzgsea KEGG library
msigdb_library = blitz.enrichr.get_library("KEGG_2021_Human")
elif table_name == "WikiPathways--blitzgsea": # Parse from blitzgsea WikiPathways library
msigdb_library = blitz.enrichr.get_library("WikiPathways_2019_Human")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this fetches remote data

@xzhou82 xzhou82 marked this pull request as draft February 6, 2025 21:11
@xzhou82
Copy link
Collaborator Author

xzhou82 commented Feb 6, 2025

HOLD OFF merging this pr wait till gdc release is done
(or change to feature toggle)
because the blitz.enrichr.get_library may not work in gdc env and may break pp there

@xzhou82 xzhou82 changed the title add a hardcoded geneset group name for blitzgseas DO NOT MERGE call blitzgseas geneset libraries Feb 6, 2025
@robinpaul85
Copy link
Contributor

robinpaul85 commented Feb 6, 2025

Now filter cutoffs and blitzgsea genesets are behind the serverconfig flag: gsea_test. add serverconfig flag: “gsea_test” to "true" in serverconfig.features.

@karishma-gangwani
Copy link
Contributor

thanks @robinpaul85 I am unable to download the GSEA table. can you look into this?
image

@karishma-gangwani
Copy link
Contributor

karishma-gangwani commented Feb 7, 2025

@robinpaul85 run wilcoxon on DE, submit GSEA analysis, then switch to edgeR add confounding factors. Now I can't run GSEA again because the option is no longer visible under DE controls.

@robinpaul85
Copy link
Contributor

thanks @robinpaul85 I am unable to download the GSEA table. can you look into this? image

Done

@karishma-gangwani
Copy link
Contributor

@robinpaul85 run wilcoxon on DE, submit GSEA analysis, then switch to edgeR add confounding factors. Now I can't run GSEA again because the option is no longer visible under DE controls.

This will be handled in a separate pr as not a breaking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants