Adding support for reading CSV files.#4
Open
vote539 wants to merge 4 commits into
Open
Conversation
Current coverage is 100% (diff: 100%)@@ master #4 diff @@
===================================
Files 1 1
Lines 78 116 +38
Methods 1 1
Messages 0 0
Branches 17 21 +4
===================================
+ Hits 78 116 +38
Misses 0 0
Partials 0 0
|
Updating async API to be fully async and not use the deprecated fs.existsSync function. Changing errors to use Error class instead of strings.
Author
|
In addition to the basic CSV support, I added a synchronous API to my branch (including tests and documentation). Note that since the dependency "excel" does not expose a synchronous API, right now the synchronous API does not support XLSX files. |
Author
|
FYI, for the time being I have made my changes available via the npm package "@vote539/excel-as-json" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for reading CSV files. This will provide better support for users who want to use this module with the option of the alternative spreadsheet format. The changes are as follows: