Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Gradle 7.2 to support JDK 8 to 16 and fix #175, #176 & #177 #178

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SingingBush
Copy link

No description provided.

@SingingBush SingingBush changed the title Update for Gradle 7 and fix #176 & #177 WIP: Update for Gradle 7 and fix #176 & #177 May 20, 2022
@SingingBush
Copy link
Author

Still working on getting tests to pass. Will update again when completed

@SingingBush SingingBush changed the title WIP: Update for Gradle 7 and fix #176 & #177 update to Gradle 7.2 to support JDK 8 to 16 and fix #176 & #177 May 21, 2022
@SingingBush
Copy link
Author

SingingBush commented May 21, 2022

There's a few things in the PR:

Updating Gradle to 7.2

I would've updated to latest but that caused tests to fail due to a Gradle regression. To be able to build with JDK 17 gradle will need to be updated to 7.4

Add Github Action

basically runs ./gradlew build check with numerous Java versions to ensure future PR's don't break anything.

Fix problem in GenerateReportTask

I'm not a Gradle Plugin expert but from what I can tell this was the appropriate way to resolve #175, #176 & #177

@SingingBush SingingBush changed the title update to Gradle 7.2 to support JDK 8 to 16 and fix #176 & #177 update to Gradle 7.2 to support JDK 8 to 16 and fix #175, #176 & #177 May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant