fix: Points argument array conversion/check #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/steveruizok/perfect-freehand-example/3AyWKWZJTA17NfHRSiULgbJAKDRP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc strings mentions either
[x, y, pressure]or{x, y, pressure}formats can be used forgetStrokeOutlinePointsandgetShortStrokeOutlinePointspoints argument.Added an argument check/conversion before calculations are done similar to how it's done in
getStrokePoints.If this is not an intended feature or expected argument, ignore this PR and just update the doc string to
@param points An array of points (as[x, y, pressure]). Pressure is optional.EDIT: Read at end of README you should always be running
getStrokePointsfirst anyway, so as mentioned above only docstrings needs updating. Closing PR