fix: Backtracking now doesn't create dots at end of lines #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Works for me! |
steveruizok
reviewed
Aug 22, 2022
| if (nextDpr < 0) { | ||
| const nextVector = (i < points.length - 1? points[i + 1] : points[i]).vector | ||
| const nextDpr = (i < points.length - 1? dpr(vector, nextVector) : 1.0) | ||
| const prevDpr = dpr(vector, prevVector) |
There was a problem hiding this comment.
Is prevDpr always equal to last iteration's nextDpr?
There was a problem hiding this comment.
Maybe! I'll check. Definitely a cleaner fix in here somewhere
There was a problem hiding this comment.
Ok so yes, they are usually the same (apart from some occasional float imprecision)
Except for very rare cases:
There was a problem hiding this comment.
Here's another example that's not from the final two iterations:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #48
This fixes a bug where sharp corners would sometimes cause a "dot" to appear at the end of a line. The bug happened because some sharp corners were not getting detected. To detect them, I made it also check the dot-product of the current point and previous point (not just the next point). Maybe a cleaner fix here, but maybe it can solve it for now.
Line 212 and 213 could be better - I made them kinda messy to avoid typescript complaining but there's probably a better way of structuring it?