Fix getStroke when there are multiple duplicates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using naive approaches to adding points, quite often we get hundreds of duplicates. Occasionally if duplicates happen in the correct sequence near the beginning of the points array, `i` would outpace the number of elements in strokePoints. I'm unsure if there are better solutions to this but this change makes sense within the scope of the loop and fixes the problems in my project.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/steveruiz/perfect-freehand-example/33wvC4wQE71wXpUkovTtLNqDaMq9 |
|
Thanks! This is a great catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using naive approaches to adding points, quite often we get hundreds of duplicates. Occasionally if duplicates happen in the correct sequence near the beginning of the points array,
iwould outpace the number of elements in strokePoints.I'm unsure if there are better solutions to this but this change makes sense within the scope of the loop and fixes the problems in my project.