Batch norm - #11
Open
YuntianLan wants to merge 2 commits into
Open
Conversation
Owner
|
Need unit testing file and benchmark file. |
stevenygd
self-requested a review
July 15, 2017 07:01
stevenygd
reviewed
Aug 11, 2017
| broadcast!(+,sqrtvar,sqrtvar,l.eps) | ||
| l.sqrtvar = deterministics ? l.sqrtvar : sqrtvar | ||
| ivar = Array{Float64}(1,D) | ||
| broadcast!(/,ivar,1,sqrtvar) |
Owner
There was a problem hiding this comment.
it seems like you haven't used the epsilon doe numerical stabiity, have you checked that whether this division will create nan?
Owner
There was a problem hiding this comment.
Never mind , I saw it, but it seems like you are the epsilon after the square root, not before, so you might want to adjust the value of epsilon for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Batch Norm layer, as well as a test at examples/MNIST\ BatchNorm.jl for benchmark.