Replacing PUT with PATCH #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ public class CostOptionDTO { | |||
| private LocalDate validTo; | |||
| private String option; | |||
| private String currency; | |||
| private int amount; | |||
| private Integer amount; | |||
There was a problem hiding this comment.
Why do we need Integer? Integer creates and Integer object, which uses more memory. Why no use the primitive int?
There was a problem hiding this comment.
int is a value type so its default initialized to 0 instead of null
src/main/java/com/sarapis/orservice/dto/upsert/UpsertLocationDTO.java
Outdated
Show resolved
Hide resolved
| @@ -90,23 +90,28 @@ public class Location { | |||
|
|
|||
| @PreRemove | |||
There was a problem hiding this comment.
What is this @PreRemove doing?
There was a problem hiding this comment.
It's setting the opposite side of the bidirectional relationship to null when the entity is delete. I think this is necessary since the relation is bidirectional.
|
@ZhangTerrence Added some comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced PUT with PATCH and so upsert dtos now support partial updates. In the case where a collection is being updated, all the existing relations in that collection are disassociated and then the only the ids given in the new collection are added back.