-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom optional visibility observer #77
Open
GeKorm
wants to merge
1
commit into
stereobooster:master
Choose a base branch
from
GeKorm:pr/custom-optional-observer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
import React, {Component} from 'react' | ||
import React, {Component, cloneElement} from 'react' | ||
import PropTypes from 'prop-types' | ||
import Waypoint from 'react-waypoint' | ||
import Media from '../Media' | ||
import {icons, loadStates} from '../constants' | ||
import {xhrLoader, imageLoader, timeout, combineCancel} from '../loaders' | ||
|
@@ -162,6 +161,10 @@ export default class IdealImage extends Component { | |
icons: PropTypes.object.isRequired, | ||
/** theme object - CSS Modules or React styles */ | ||
theme: PropTypes.object.isRequired, | ||
/** visibility observer component, like react-waypoint */ | ||
observer: PropTypes.func, | ||
/** visibility observer component, like react-waypoint */ | ||
children: PropTypes.oneOfType([PropTypes.func, PropTypes.element]), | ||
} | ||
|
||
static defaultProps = { | ||
|
@@ -320,8 +323,10 @@ export default class IdealImage extends Component { | |
...this.state, | ||
size: pickedSrc.size, | ||
}) | ||
this.setState({pickedSrc, shouldAutoDownload, url}) | ||
if (shouldAutoDownload) this.load(false) | ||
this.setState( | ||
{pickedSrc, shouldAutoDownload, url}, | ||
shouldAutoDownload ? () => this.load(false) : undefined, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's important for this to be callback otherwise this.load could have stale state (I encountered this with url being undefined) |
||
) | ||
} | ||
|
||
onLeave = () => { | ||
|
@@ -332,20 +337,41 @@ export default class IdealImage extends Component { | |
} | ||
|
||
render() { | ||
const {children, observer} = this.props | ||
const icon = this.props.getIcon(this.state) | ||
const message = this.props.getMessage(icon, this.state) | ||
return ( | ||
<Waypoint onEnter={this.onEnter} onLeave={this.onLeave}> | ||
<Media | ||
{...this.props} | ||
{...fallbackParams(this.props)} | ||
onClick={this.onClick} | ||
icon={icon} | ||
src={this.state.url || ''} | ||
onDimensions={dimensions => this.setState({dimensions})} | ||
message={message} | ||
/> | ||
</Waypoint> | ||
const observerMethod = observer || children | ||
const media = ( | ||
<Media | ||
{...this.props} | ||
{...fallbackParams(this.props)} | ||
onClick={this.onClick} | ||
icon={icon} | ||
src={this.state.url || ''} | ||
onDimensions={dimensions => | ||
this.setState( | ||
{dimensions}, | ||
observerMethod ? undefined : this.onEnter, | ||
) | ||
} | ||
message={message} | ||
/> | ||
) | ||
|
||
if (observer || typeof children === 'function') { | ||
return ( | ||
<observerMethod onEnter={this.onEnter} onLeave={this.onLeave}> | ||
{media} | ||
</observerMethod> | ||
) | ||
} else if (children) { | ||
return cloneElement( | ||
children, | ||
{onEnter: this.onEnter, onLeave: this.onLeave}, | ||
media, | ||
) | ||
} else { | ||
return media | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started working on this PR mainly because I needed to provide
scrollableAncestor="window"
. Lazy-loading didn't work at all without this. I'm guessing it's either due to SSR oroverflow: auto
in a parent, both common scenarios.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not because of SSR (SSR should be properly handled)