Chore(docs): need to finish documenting core props

stereobooster · Jun 6, 2023 · e342e6f · e342e6f
1 parent e661536
commit e342e6f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -27,7 +27,7 @@ const App = () => (
     /* see framer-motion docs */
     /* motionProps={} */
     alt="ideal image"
-    // you should also add specific width & height set to numbers
+    // you could include specific width & height set to numbers
     srcSet={[{ src: "some/image.webp" }]}
     // prefer passing width && height set to numbers
     width={"100%"}

diff --git a/src/IdealImage.tsx b/src/IdealImage.tsx
@@ -56,11 +56,6 @@ export const IdealImage: FC<IdealImageInterface> = ({
   theme = {},
   threshold,
 }) => {
-  const useIcons = {
-    ...iconMap,
-    ...icons,
-  };
-
   const useTheme = useMemo(
     () => ({
       ...defaultTheme,
@@ -323,9 +318,12 @@ export const IdealImage: FC<IdealImageInterface> = ({
       getIcon({
         imgState,
         networkState,
-        icons: useIcons,
+        icons: {
+          ...iconMap,
+          ...icons,
+        },
       }),
-    [useIcons, imgState, networkState]
+    [icons, imgState, networkState, getIcon]
   );
 
   return (