Add suport for offline load generation; switch maxTPSTest to it#257
Merged
marta-lokhova merged 1 commit intostellar:mainfrom Mar 28, 2025
Merged
Add suport for offline load generation; switch maxTPSTest to it#257marta-lokhova merged 1 commit intostellar:mainfrom
marta-lokhova merged 1 commit intostellar:mainfrom
Conversation
SirTyson
requested changes
Mar 27, 2025
Contributor
SirTyson
left a comment
SirTyson
left a comment
There was a problem hiding this comment.
I'm excited to try this out! Overall looks good, but I think the enable-parallel-apply option is broken. Other than that just a few nits.
anupsdf
reviewed
Mar 27, 2025
marta-lokhova
force-pushed
the
offlineLoadgen
branch
2 times, most recently
from
27967a8 to
15e50ae
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (12)
- src/App/Program.fs: Language not supported
- src/FSLibrary.Tests/Tests.fs: Language not supported
- src/FSLibrary/MaxTPSTest.fs: Language not supported
- src/FSLibrary/MissionDatabaseInplaceUpgrade.fs: Language not supported
- src/FSLibrary/MissionMaxTPSClassic.fs: Language not supported
- src/FSLibrary/MissionVersionMixConsensus.fs: Language not supported
- src/FSLibrary/PollRetry.fs: Language not supported
- src/FSLibrary/StellarCoreCfg.fs: Language not supported
- src/FSLibrary/StellarCoreHTTP.fs: Language not supported
- src/FSLibrary/StellarCoreSet.fs: Language not supported
- src/FSLibrary/StellarKubeSpecs.fs: Language not supported
- src/FSLibrary/StellarMissionContext.fs: Language not supported
Contributor
Author
SirTyson
approved these changes
Mar 28, 2025
Contributor
SirTyson
left a comment
SirTyson
left a comment
There was a problem hiding this comment.
LGTM, but still one nit.
marta-lokhova
force-pushed
the
offlineLoadgen
branch
from
15e50ae to
b0c721a
Compare
SirTyson
approved these changes
Mar 28, 2025
This was referenced Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.