Allow disabling of skipping known results in pubnet catchup#251
Merged
jayz22 merged 1 commit intostellar:mainfrom Mar 7, 2025
Merged
Conversation
The `--catchup-skip-known-results-for-testing` flag was implemented as a 0 argument flag whose presence enables the feature. However, the flag was also enabled by default, leaving no way to turn it off. This changes the flag to an option that takes a boolean argument, allowing for the flag to be disabled by setting it to false (--catchup-skip-known-results-for-testing=false).
jayz22
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--catchup-skip-known-results-for-testingflag was implemented as a 0 argument flag whose presence enables the feature. However, the flag was also enabled by default, leaving no way to turn it off. This changes the flag to an option that takes a boolean argument, allowing for the flag to be disabled by setting it to false(--catchup-skip-known-results-for-testing=false).