Propagate flag for updating Soroban costs to the relevant missions.#234
Merged
dmkozh merged 1 commit intostellar:mainfrom Jan 2, 2025
Merged
Propagate flag for updating Soroban costs to the relevant missions.#234dmkozh merged 1 commit intostellar:mainfrom
dmkozh merged 1 commit intostellar:mainfrom
Conversation
sisuresh
approved these changes
Jan 2, 2025
The flag has been added to all the missions that generate Soroban load and don't use the nodes with the old image. While the fix is necessary only for 'invoke' load, it makes sense to have all the Soroban missions to use the proper costs.
bboston7
added a commit
to bboston7/supercluster
that referenced
this pull request
Jun 27, 2025
This change accomplishes a couple things: 1. `simulatePubnetMixedLoad` was experiencing issues with loadgen failing during invoke setup. It seems like this is a known issue that stellar#234 resolved for the other soroban missions, but this mission was missed. This change applies the same fix from that PR to this mission. 2. This change increases the default percentage of soroban transactions for mixed modes from 1% to 5%. It also increases the TPS rate for the test from 202 to 210. This distribution more closely matches what we see on pubnet.
bboston7
added a commit
to bboston7/supercluster
that referenced
this pull request
Jun 27, 2025
This change accomplishes a couple things: 1. `simulatePubnetMixedLoad` was experiencing issues with loadgen failing during invoke setup. It seems like this is a known issue that stellar#234 resolved for the other soroban missions, but this mission was missed. This change applies the same fix from that PR to this mission. 2. This change increases the default percentage of soroban transactions for mixed modes from 1% to 5%. It also increases the TPS rate for the test from 202 to 210. This distribution more closely matches what we see on pubnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag has been added to all the missions that generate Soroban load and don't use the nodes with the old image. While the fix is necessary only for 'invoke' load, it makes sense to have all the Soroban missions to use the proper costs.