Skip to content

Sort community skills alphabetically - #111

Open
mariaelisaaraya wants to merge 1 commit into
stellar:mainfrom
mariaelisaaraya:sort-ecosystem-cards-alphabetically
Open

Sort community skills alphabetically#111
mariaelisaaraya wants to merge 1 commit into
stellar:mainfrom
mariaelisaaraya:sort-ecosystem-cards-alphabetically

Conversation

@mariaelisaaraya

Copy link
Copy Markdown
Contributor

Community skills were ordered by when each PR got merged, so new entries always landed on the last page. This sorts them alphabetically by title instead, so a skill's position depends on its name, not on when it was added.

Also updated CLAUDE.md so future entries get inserted in the right spot instead of appended at the end.

Test plan:

  • pnpm lint:ts
  • pnpm lint
  • pnpm build
  • Verified locally with pnpm dev

Copilot AI balanced review requested due to automatic review settings August 21, 2026 04:09
@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

👀 Picked this up — a review will follow shortly.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sorts community skills alphabetically for stable display ordering.

Changes:

  • Reorders ECOSYSTEM_CARDS by title.
  • Documents the ordering requirement.
  • Cleans stray characters from a description.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
site/src/data/skills.ts Alphabetizes community skill cards.
site/CLAUDE.md Adds alphabetical insertion guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread site/CLAUDE.md
Comment on lines +88 to +90
other wiring needed. Insert the entry alphabetically by `title`
(case-insensitive) in `ECOSYSTEM_CARDS`, not appended at the end, so a
card's position reflects its name rather than merge order.

@devodii devodii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we make sure newer submissions follow this convention?

@drQedwards

Copy link
Copy Markdown
Contributor

you would make sure like in contract-metadata to denote in the documentation not to append your skills to end of the list.

you would code a flag check that would check to see if the developer of the new skill follow alphabetical instructions by if they put their ecosystem card code in the correct slot in the JSON or just put in the first or last position.

alphanumeric-check.yml I recommend adding

@devodii

devodii commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

yeah that's a good approach, wdyt @mariaelisaaraya

@mariaelisaaraya

Copy link
Copy Markdown
Contributor Author

Hi! The alphabetical sort was the goal of this PR. Docs in CLAUDE.md should be enough for now. A CI check can be a follow-up if the list starts drifting again.

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Thanks for this. Merge-order placement was a real annoyance, and sorting by
title fixes it at the source.

I checked the reorder line by line:

  • The 29 community cards are the same set before and after. Nothing was lost
    or added.
  • Every card field is byte-identical to main, except the StellarTools
    description. There you removed two invisible characters (U+202F and U+2060).
    Good catch.
  • The new order is correct alphabetically by title, case-insensitive.
  • page.tsx builds searchTexts and the cards from the same array, so the
    two stay aligned after a reorder.

One item is still open from Copilot's review:

  • site/README.md:146 still says "Append to ECOSYSTEM_CARDS". Contributors
    who read the README will keep appending. Please update that line the way you
    updated site/CLAUDE.md. I could not push the fix myself, because my token
    has no write access to your fork.

On the CI check that @devodii and @drQedwards suggested: your answer reads
right to me. Document it first, then add a check if the list drifts again.

Two points need Kaan:

  • The preview workflow skips pull requests from forks. So lint, lint:ts
    and build have no CI result here. Your local runs are the only evidence.
  • This PR rewrites the whole ECOSYSTEM_CARDS region, so it conflicts with
    every open card PR. The merge order is a maintainer call.

@kaankacar those two are yours. I opened a tracking issue.

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Thanks for the patience here, and thanks @drQedwards for offering the drift
check.

Your sort itself still verifies from the last round. But #103 merged since
then, and this branch now conflicts.

Please rebase on main and apply the sort there. Please do not resolve the
conflict line by line. That puts the 28 blob URLs back.

Two notes that help you:

  • main now runs pnpm check:ecosystem-links. It rejects a blob-URL
    copyValue, so it would fail on this head today.
  • Fork PRs now get CI from the site-ci check. Your next push runs lint,
    lint:ts, the gate and build. That is the build evidence this PR was
    missing.

Still open from last round: site/README.md:150 says "Append to
ECOSYSTEM_CARDS". #103 edited that file but kept that wording. Please update
it the way you updated site/CLAUDE.md. I cannot push to your fork.

A CI drift check is welcome as its own PR. It should not block this one.

@kaankacar the hold (kaankacar/Automated-Triage-Bot#31) still applies. Merge
order stays yours.

Community skills were ordered by when each PR got merged, so newer
entries always landed on the last page. This sorts them alphabetically
by title instead, so a skill's position depends on its name, not on
when it was added.

Also updated CLAUDE.md so new entries get inserted in the right spot
going forward, instead of appended at the end.
Copilot AI review requested due to automatic review settings September 1, 2026 14:10
@mariaelisaaraya
mariaelisaaraya force-pushed the sort-ecosystem-cards-alphabetically branch from 508f1a9 to d35beeb Compare September 1, 2026 14:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Thanks for coming back and doing the rebase. Both open items from last round
are now closed.

What I checked at d35beeb:

  • The branch sits directly on current main. No conflict.
  • Still a pure permutation: the same 29 cards, with pathLabel and
    copyValue byte-identical to main.
  • Zero /blob/ URLs. All 28 GitHub links stay on
    raw.githubusercontent.com, so fix: point ECOSYSTEM_CARDS copyValue at raw content, not GitHub's blob HTML page #103 survived the rebase.
  • One content change only: the StellarTools description drops the trailing
    U+202F and U+2060.
  • The order is exactly case-insensitive alphabetical by title.
  • Every change stays inside the ECOSYSTEM_CARDS region.
  • site/README.md now teaches alphabetical insertion. That closes the last
    open item.
  • site-ci is green at this head: lint, lint:ts,
    check:ecosystem-links, test:ecosystem-links and build. That is the
    build evidence this PR missed before.
  • llms.txt reads the same array, so it becomes alphabetical too.

The conflict worry from last round is gone. #116 merges clean with this
branch. #55 and #49 already conflict with main today, with or without this
PR.

I am not merging, and that is not about your work. @drQedwards opened #122
with the same change while this branch was stale. The two heads match, except
one sentence of wording in site/README.md. Which PR carries the change is
@kaankacar's call. The hold is kaankacar/Automated-Triage-Bot#31.

@drQedwards

drQedwards commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🙄 one sentence of wording. So picky, Sir Bot.

I got it hold on.

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

@drQedwards fair point, and sorry if that read as nitpicking. The wording is
not a problem. I named it because it is the only difference between the two
branches.

I re-checked both heads just now:

  • main has not moved. Both branches sit on 254aff4.
  • The trees differ in one site/README.md sentence only. Both teach
    alphabetical insertion, so either wording is correct.
  • site-ci is green here at d35beeb.

Nothing needs a fix on either PR. The only open question is which PR carries
the change. That is @kaankacar's call. The hold is
kaankacar/Automated-Triage-Bot#31.

@mariaelisaaraya nothing is needed from you either. Thanks again for the
rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants