keypair: validate payload length in ParseAddress to prevent panic#5908
Merged
karthikiyer56 merged 5 commits intomainfrom Feb 19, 2026
Merged
keypair: validate payload length in ParseAddress to prevent panic#5908karthikiyer56 merged 5 commits intomainfrom
karthikiyer56 merged 5 commits intomainfrom
Conversation
strkey.Decode() accepts payloads of any length with valid checksums. Without length validation, short G-addresses could pass ParseAddress() and later cause panics in Hint() or Verify() methods. Add explicit 32-byte length check in newFromAddress() to reject malformed addresses early with ErrInvalidKey.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens keypair.ParseAddress() against malformed G-addresses by validating the decoded payload length before constructing an ed25519.PublicKey, preventing downstream panics in Hint()/Verify() when given short/long payloads.
Changes:
- Add an explicit 32-byte payload length check in
newFromAddress()and returnErrInvalidKeyon mismatch. - Add unit tests covering short payload, long payload, and valid 32-byte payload cases for
ParseAddress().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
keypair/from_address.go |
Adds payload length validation after strkey.Decode() to reject malformed addresses early. |
keypair/from_address_test.go |
Adds regression tests ensuring ParseAddress() rejects non-32-byte payloads and accepts valid payloads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@karthikiyer56 I've opened a new pull request, #5910, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tamirms
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strkey.Decode() accepts payloads of any length with valid checksums. Without length validation, short G-addresses could pass ParseAddress() and later cause panics in Hint() or Verify() methods.
Add explicit 32-byte length check in newFromAddress() to reject malformed addresses early with ErrInvalidKey.
Fixes #5901