txnbuild: Add client domain support for sep 10#5822
Open
OwenJacob wants to merge 4 commits intostellar:mainfrom
Open
txnbuild: Add client domain support for sep 10#5822OwenJacob wants to merge 4 commits intostellar:mainfrom
OwenJacob wants to merge 4 commits intostellar:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for client domains in SEP-10 challenge transactions by introducing new functions BuildChallengeTxWithClientDomain and ReadChallengeTxWithClientDomain. This enhancement allows clients to specify a domain they control during the authentication flow, improving security and alignment with the SEP-10 specification.
Key changes:
- Added
BuildChallengeTxWithClientDomainfunction that extends challenge transaction building with optional client domain support - Added
ReadChallengeTxWithClientDomainfunction that validates client domain operations during challenge verification - Refactored existing functions to use the new implementations while maintaining backward compatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| txnbuild/transaction.go | Implements core client domain functionality with new build and read functions |
| txnbuild/transaction_test.go | Adds comprehensive test coverage for client domain scenarios including validation and error cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Adds support for client domains in build and read challenge transactions
Why
Closes a long outstanding issue #3780 and aligns the Go txnbuild package with SEP-10
Known limitations
I decided not to break the existing API 😅