feat(governance): make governance parameters configurable with valida… - #17
Merged
Meshmulla merged 1 commit intoJul 22, 2026
Conversation
…tion and events - Add comprehensive validation for all governance parameters (quorum, threshold, voting periods) - Emit events when configuration parameters are updated via update_config() - Enforce constraints: quorum/threshold in 0-100%, voting_period > 0, non-negative delays - Add new GovernanceEventType enum for parameter change notifications - Support initialization with zero voting_delay and zero timelock_delay - Add 21 new test cases covering parameter validation and edge cases - Test proposal lifecycles under different quorum and threshold configurations - Document parameter units and constraints with inline comments Fixes: stellar-kracken#9
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Governance Parameters Configuration
Make governance quorum, voting delay, voting period, and approval thresholds configurable with comprehensive validation and event emissions.
Changes
Testing
Closes #9