Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

fixed broken install in docker file #52

Merged
merged 2 commits into from
Dec 10, 2020
Merged

fixed broken install in docker file #52

merged 2 commits into from
Dec 10, 2020

Conversation

maorgoldberg
Copy link
Contributor

Fixed issue that caused curl version to break the docker file by updating its version.

@maorgoldberg maorgoldberg mentioned this pull request Dec 10, 2020
Closed
stefanprodan
stefanprodan suggested changes Dec 10, 2020
View reviewed changes
Dockerfile Outdated
@@ -1,6 +1,6 @@
FROM garethr/kubeval:0.15.0

RUN apk --no-cache add curl==7.67.0-r1 bash==5.0.11-r1 git==2.24.3-r0 openssh-client==8.1_p1-r0
RUN apk --no-cache add curl==7.67.0-r2 bash==5.0.11-r1 git==2.24.3-r0 openssh-client==8.1_p1-r0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the version pinning for all packages

@maorgoldberg
Copy link
Contributor Author

Removing version pinning causes checks to fail

@stefanprodan
Copy link
Owner

That lint rule is kinda silly, we need to remove it.

@maorgoldberg
Copy link
Contributor Author

Yea I'll take a look at the linting action and add an ignore for it and create a separate pr for it. However this one should fix dockerfile errors without issue regardless of the failed lint

stefanprodan
stefanprodan approved these changes Dec 10, 2020
View reviewed changes
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @maorgoldberg

@stefanprodan stefanprodan merged commit 2d715fa into stefanprodan:master Dec 10, 2020
@stevenpall
Copy link
Contributor

Could we please get a new release cut that includes this fix? We try not to use @master.

@maorgoldberg
Copy link
Contributor Author

Could we please get a new release cut that includes this fix? We try not to use @master.

Is an action needed on my part?

@stevenpall
Copy link
Contributor

Could we please get a new release cut that includes this fix? We try not to use @master.

Is an action needed on my part?

Nope, all good now. The v3.5.0 release includes this fix. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maorgoldberg @stefanprodan @stevenpall