Open
Conversation
orbitalflower
suggested changes
Jul 1, 2024
orbitalflower
left a comment
There was a problem hiding this comment.
Testing this in current crunpyroll (2.4.1). It works, but:
- If date is unspecified, it defaults to today's date. It should probably default to not filter by date at all. This is the default in the API, and matches the browse functionality that was in crunpyroll v1. Always filtering to a single day is not very useful when browsing series or movies, where no new series are released on most days.
- In the API, leaving "type" blank will return series and movies together. This should probably be the default, since it's a common use case and can't otherwise be specified by a single
ContentType. (Another possibility is to change thefilterparamter tofiltersand have it take a List for consistency with thesearchmethod parameters, although as far as I can tell the only valid multiple-entry parameter would be the series+movies combination. which would in reality be sent as a blank or empty parameter) - The
.gitignoreadditions are probably unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this great project :D
To improve it, I've added support for
content/v2/discover/browse.This allows you to retrieve content recently released on the platform
Hoping it will be useful