Added a Swift implementation of SiriWaveformView#11
Open
Felizolinha wants to merge 1 commit intostefanceriu:masterfrom
Open
Added a Swift implementation of SiriWaveformView#11Felizolinha wants to merge 1 commit intostefanceriu:masterfrom
Felizolinha wants to merge 1 commit intostefanceriu:masterfrom
Conversation
Owner
|
Hey, thank you for raising this pull request. Although swift is cool and whatnot I don't really see a reason for it to be part of this repository though. In the mean time, I'm going to leave this pull request open just in case anybody needs a swift version. |
notDanish
approved these changes
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented your SCSiriWaveformView in Swift, I thought it would be cool to share it here as others might need it!