Skip to content

chore: use existing BLAS implementation for ml/incr/kmeans/lib/euclidean #8530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
+18 −19
Draft

chore: use existing BLAS implementation for ml/incr/kmeans/lib/euclidean #8530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9680d6b
chore: use existing BLAS implementation for `ml/incr/kmeans/lib/eucli…
nakul-krishnakumar Nov 14, 2025
06cbbe1
style: remove empty lines
nakul-krishnakumar Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions lib/node_modules/@stdlib/ml/incr/kmeans/lib/euclidean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2018 The Stdlib Authors.
* Copyright (c) 2025 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -20,7 +20,16 @@

// MODULES //

var sqrt = require( '@stdlib/math/base/special/sqrt' );
var dnrm2 = require( '@stdlib/blas/base/dnrm2' );
var dcopy = require( '@stdlib/blas/base/dcopy' );
var daxpy = require( '@stdlib/blas/base/daxpy' );
var Float64Array = require( '@stdlib/array/float64' );


// VARIABLES //

// to compute X + (-1)*Y

Check warning on line 31 in lib/node_modules/@stdlib/ml/incr/kmeans/lib/euclidean.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Comments should begin with an uppercase character
var ALPHA = -1;


// MAIN //
Expand All @@ -38,23 +47,13 @@
* @param {NonNegativeInteger} offsetY - index offset
* @returns {number} Euclidean distance
*/
function euclidean( N, X, strideX, offsetX, Y, strideY, offsetY ) { // TODO: remove and use BLAS implementation
var xi;
var yi;
var d;
var s;
var i;

xi = offsetX;
yi = offsetY;
s = 0.0;
for ( i = 0; i < N; i++ ) {
d = X[ xi ] - Y[ yi ];
s += d * d;
xi += strideX;
yi += strideY;
}
return sqrt( s );
function euclidean( N, X, strideX, offsetX, Y, strideY, offsetY ) {
var diff;

diff = new Float64Array( N );
dcopy.ndarray( N, X, strideX, offsetX, diff, 1, 0 ); // Magic number `0` for offset since `diff` is contiguous
Copy link
Contributor Author

@nakul-krishnakumar nakul-krishnakumar Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this comment referring to https://github.com/stdlib-js/stdlib/blob/64199dbd0d482a85d0239828690b4c6a5eaf4b15/lib/node_modules/%40stdlib/ml/incr/kmeans/lib/main.js#L339C64-L339C154
Please let me know if the comment is unnecessary.

daxpy.ndarray( N, ALPHA, Y, strideY, offsetY, diff, 1, 0 );
return dnrm2( N, diff, 1 );
}


Expand Down