Skip to content

test: add missing tests to ndarray/base/every #7235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

test: add missing tests to ndarray/base/every #7235

wants to merge 7 commits into from

Conversation

headlessNode
Copy link
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

  • add tests for 100% code coverage.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
test: add 1d tests
8537fc1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Tests Pull requests specifically adding tests. labels Jun 6, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 6, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/every $\color{red}5730/12006$
$\color{green}+47.73\%$ 		$\color{red}186/192$
$\color{green}+96.88\%$ 		$\color{red}13/64$
$\color{green}+20.31\%$ 		$\color{red}5730/12006$
$\color{green}+47.73\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
test: add 2d tests
fa882bd 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
headlessNode
headlessNode commented Jun 6, 2025
View reviewed changes
@headlessNode
chore: fix comment
d56c204 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode headlessNode requested a review from kgryte June 6, 2025 12:12
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 6, 2025
@headlessNode headlessNode mentioned this pull request Jun 9, 2025
Open
@headlessNode
fix: data type
7f886c4 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
Copy link
Member Author

Headsup, working on 100% coverage for accessors.

@headlessNode
fix: coverage
4b84791 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
headlessNode
headlessNode commented Jun 10, 2025
View reviewed changes
headlessNode
headlessNode commented Jun 10, 2025
View reviewed changes
@headlessNode
fix: import
d28a6af 
Signed-off-by: Muhammad Haris <[email protected]>
kgryte
kgryte reviewed Jun 11, 2025
View reviewed changes
lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js
dt = 'complex128';
ord = 'column-major';
sh = [ 2, 2 ];
st = [ 4, -1 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strides are incorrect here.

kgryte
kgryte reviewed Jun 11, 2025
View reviewed changes
lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js
dt = 'float64';
ord = 'column-major';
sh = [ 2, 2 ];
st = [ 4, -1 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strides are incorrect here.

kgryte
kgryte reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the two instances where strides are not in column-major order, these tests are looking good.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @stdlib-bot @kgryte