feat: add `math/base/special/logitf` by vivekmaurya001 · Pull Request #3367 · stdlib-js/stdlib

vivekmaurya001 · 2024-12-07T19:20:36Z

Progresses #649

Description

adds math/base/special/logitf, which would be the single-precision equivalent for math/base/special/logit.

This pull request:

Progresses: [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

…o logitf

stdlib-bot · 2024-12-07T19:23:14Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/logitf	$\color{green}192/192$ $\color{green}+100.00\%$	$\color{green}13/13$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}192/192$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter · 2024-12-07T19:31:26Z

/stdlib update-copyright-years

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

vivekmaurya001 · 2025-01-18T14:17:40Z

/stdlib update-copyright-years

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…o logitf --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

vivekmaurya001 · 2025-01-18T15:37:59Z

Hi @gunjjoshi , i have made the changes according to recent PR discussions , can u please check

vivekmaurya001 · 2025-03-07T06:38:19Z

@gunjjoshi , @Planeshifter , Is this PR need some changes or is it good to go ?

gunjjoshi · 2025-03-07T07:00:20Z

+double logit( double x ) {
+	if ( x != x ) {
+		return x;
+	}
+	if ( x < 0.0 || x > 1.0 ) {
+		return NAN;
+	}
+	if ( x == 0.0 ) {
+		return -HUGE_VAL;
+	}
+	if ( x == 1.0 ) {
+		return HUGE_VAL;
+	}
+	return log( x / ( 1.0 - x ) );
+}


@vivekmaurya001 This must be modified for single-precision.

Oh, sorry I didn't notice it

gunjjoshi · 2025-03-07T07:00:37Z

+	double y;
+	double t;
+	int i;
+
+	t = tic();
+	for ( i = 0; i < ITERATIONS; i++ ) {
+		y = logit( rand_double() );
+		if ( y != y ) {
+			printf( "should not return NaN\n" );
+			break;
+		}
+	}
+	elapsed = tic() - t;
+	if ( y != y ) {
+		printf( "should not return NaN\n" );
+	}
+	return elapsed;


Same goes for this too.

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

…ndex.d.ts Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

gunjjoshi · 2025-03-07T07:32:36Z

Tested this PR locally. The tolerance of 15.0 * EPS isn't required in test.native.js, for the C implementation. But, that is required in test.js, for the JS implementation. Any reason to keep the same tolerance level of 15.0 * EPS in test.native.js as well, even though it wasn't required, @vivekmaurya001?

vivekmaurya001 · 2025-03-08T13:32:47Z

@gunjjoshi, I didnt realised it I thought the test file was requiring so this file also required it at that time while testing native file got skipped, sorry about that

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: passed - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

vivekmaurya001 · 2025-03-08T14:35:15Z

/stdlib update-copyright-years

anandkaranubc · 2025-04-17T08:34:19Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc · 2025-04-17T09:35:25Z

+	if ( p === 1.0 ) {
+		return PINF;
+	}
+	return lnf( float64ToFloat32( p / float64ToFloat32( 1.0-p ) ) );


The need for a higher tolerance threshold in the JS tests is no longer necessary with this change. Previously, without using float64ToFloat32, calculations were elevated to double precision, resulting in different outputs.

anandkaranubc

Good to go! Thanks @vivekmaurya001 and @gunjjoshi!

Planeshifter

Let's get it in. Thanks, everyone!

vivekmaurya001 added 2 commits December 8, 2024 00:46

feat(math): add math/base/special/logitf

084c777

Merge branch 'logitf' of https://github.com/vivekmaurya001/stdlib int…

fba8f2c

…o logitf

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 7, 2024

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024

chore: update copyright years

92cc9c6

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024

gunjjoshi reviewed Dec 24, 2024

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/logitf/src/main.c Outdated

gunjjoshi added status: Blocked Issue or pull request which is currently blocked. and removed Needs Review A pull request which needs code review. labels Dec 24, 2024

vivekmaurya001 and others added 2 commits January 18, 2025 19:08

Merge branch 'stdlib-js:develop' into logitf

33ea60a

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025

chore: update copyright years

2e3dce0

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025

vivekmaurya001 added 2 commits January 18, 2025 14:29

vivekmaurya001 marked this pull request as draft January 18, 2025 14:30

vivekmaurya001 marked this pull request as ready for review January 18, 2025 15:33

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2025

vivekmaurya001 added 2 commits January 18, 2025 16:27

add math/base/special/logitf

5a0da6c

add math/base/special/logitf

b600358

kgryte removed the status: Blocked Issue or pull request which is currently blocked. label Jan 18, 2025

gunjjoshi requested changes Mar 7, 2025

View reviewed changes

gunjjoshi reviewed Mar 7, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/logitf/docs/types/index.d.ts Outdated

gunjjoshi reviewed Mar 7, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/math/base/special/logitf/test/test.js Outdated

gunjjoshi added 2 commits March 7, 2025 12:59

Apply suggestions from code review

41a7874

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Update lib/node_modules/@stdlib/math/base/special/logitf/docs/types/i…

4348720

…ndex.d.ts Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

vivekmaurya001 added 2 commits March 7, 2025 14:34

Merge branch 'stdlib-js:develop' into logitf

d4d2a4a

Merge branch 'stdlib-js:develop' into logitf

04761f2

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 8, 2025

chore: update copyright years

3327eed

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 8, 2025

kgryte requested a review from anandkaranubc April 16, 2025 00:17

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 17, 2025

Merge remote-tracking branch 'upstream/develop' into logitf

a975a76

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 17, 2025

anandkaranubc added 7 commits April 17, 2025 02:17

anandkaranubc reviewed Apr 17, 2025

View reviewed changes

anandkaranubc approved these changes Apr 17, 2025

View reviewed changes

Planeshifter approved these changes Apr 29, 2025

View reviewed changes

Planeshifter added the Ready To Merge label Apr 29, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 29, 2025

Planeshifter merged commit 4fd384d into stdlib-js:develop Apr 29, 2025

Uh oh!

Conversation

vivekmaurya001 commented Dec 7, 2024

Description

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter commented Dec 7, 2024

Uh oh!

Uh oh!

vivekmaurya001 commented Jan 18, 2025

Uh oh!

vivekmaurya001 commented Jan 18, 2025

Uh oh!

vivekmaurya001 commented Mar 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gunjjoshi Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

vivekmaurya001 Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

vivekmaurya001 Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gunjjoshi commented Mar 7, 2025

Uh oh!

vivekmaurya001 commented Mar 8, 2025

Uh oh!

vivekmaurya001 commented Mar 8, 2025

Uh oh!

anandkaranubc commented Apr 17, 2025

Uh oh!

anandkaranubc Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

stdlib-bot commented Dec 7, 2024 •

edited

Loading