Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lapack/base/dlartv #2842

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: add lapack/base/dlartv #2842

wants to merge 3 commits into from

Conversation

Pranavchiku
Copy link
Member

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds JS implementation of lapack/base/dlartv.

Related Issues

Does this pull request have any related issues?

NA

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). labels Aug 28, 2024
kgryte
kgryte reviewed Sep 17, 2024
View reviewed changes
lib/node_modules/@stdlib/lapack/base/dlartv/lib/base.js
var i;

for ( i = 0; i < N; i++ ) {
xi = X[ offsetX + ( i * strideX ) ];
Copy link
Member

@kgryte kgryte Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranavchiku Please refactor to reduce flops. This is a common occurrence in your PRs. E.g.,

iy = offsetY;
for ( i = 0; i < N; i++ ) {
	yi = Y[ iy ];

	// ...

	iy += strideY;
}

Notice how for every pointer computation, you have 2 flops (1 multiplication and 1 addition). Notice in the example above, there is a single flop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While temporary variables are not without cost, they will certainly help improve readability in the logic which follows.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte