test_: run wakuext tests on light client as well #6518
Conversation
Jenkins BuildsClick to see older builds (26)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6518 +/- ##
===========================================
+ Coverage 60.32% 60.44% +0.12%
===========================================
Files 830 830
Lines 103573 103573
===========================================
+ Hits 62476 62604 +128
+ Misses 33566 33487 -79
+ Partials 7531 7482 -49
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi @igor-sirotin I've enabled the waku tests to run also on light client but the tests are less reliable when light mode is enabled: |
|
@fbarbu15 thanks for doing this ❤️
This is very interesting. Let's wait a bit until #6515 is merged and re-run these tests after. If the issues persists, then I believe they are legit and deserves investigation on |
fbarbu15
force-pushed
the
test-run-on-waku-light-client
branch
from
a72eedd to
59bd7be
Compare
hi, local nodes are indeed helping and the the fail rate decreased to only 1 test (from 9): https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Ftests-rpc/detail/PR-6518/6/tests |
|
We've been consistently facing issues with delays in 1-1 messaging (on and off) , and it’s been quite hard to pinpoint the root cause when testing purely from the client side. With these tests, it feels like we're getting closer to identifying the underlying issue—likely involving both status-go and the Waku fleets. It’s great to see this effort coming to life! Let me know if I can support in any way. |
|
@fbarbu15 thanks for doing this 👍 The flaky testLooks like just a schema issue. status-go/protocol/common/message.go Lines 217 to 218 in f7d73be
I've restarted the tests to see if the same test fails, or anything else. The production fleetThis is vert interesting that this test passes with a local fleet, but fails with real fleet. All eyes on this 👀 @Ivansete-status @plopezlpz @fbarbu15, would be nice if you guys can collaborate on this investigation. I will only be able to help somewhere after the offsite. |
Thanks for looking into it, I removed the optional param for now |
There was a problem hiding this comment.
LGTM, thanks @fbarbu15!
Just one thing:
can you please run the test suite ~5-10 times before merging to ensure it's working perfectly in light mode? 🙏
Just to prevent potential developers frustration of flaky tests 😄
I've run it several times and the light mode tests are stable |
No description provided.